Dead project?

Apr 29, 2012 at 6:10 PM

I notice that patches are being submitted but that they are not being accepted since a few years ago.

I hereby volunteer myself as a dev (I've submitted a patch already), I just need someone on the team to OK it.

If you chaps are too busy, all you need to do is add me as a dev and I'll see what I can do.

 

Regards

 

Ryan

Sep 29, 2012 at 4:22 AM

Since you're not getting a reply, and as this project is licensed under a MIT license, it should be kosher to create a spin-off project. I'd be willing to contribute, although the BIFF part of this library seems a little over my technical level...

Sep 29, 2012 at 9:27 AM

I'm up for that, I have not got the time right now to set up a new project but if you can manage that bit, I'll submit my patch and can jump in then?

I don't mind which open source web site is used (as long as I don't have to touch Team System) so GitHub or CodePlex is good.

You willing? If you want to co-ordinate via email I'm at r at ryanoneill dot com

Oct 1, 2012 at 7:38 PM

I'm willing to run with it if required.. it's a core component.

Oct 1, 2012 at 7:42 PM

Excellent, I'll put a reminder in my diary to take a look at setting this up in two weeks from now, unless either of you get there first. I'm just working flat out at the moment.

Oct 17, 2012 at 5:16 PM

Hi all,

I just submitted a patch for the BOOLERR issue, but hen I found that iansansom has already written code for this. 

I have contacted "ExcelDataReader" and asked if he can set one of us as the project coordinator.

Oct 17, 2012 at 5:18 PM

That's good, I've got a note to start on this but still busy. It would be good to keep it here rather than fork.

Oct 17, 2012 at 8:42 PM

Yes i would definitively want to be a coordinator..

 

Otherwise i will proceed with the Fork.

 

Oct 17, 2012 at 8:52 PM

Ah, sorry, I didn't mean to imply I'm actually coordinating anything yet. Was hoping you would get control and let us all in or we'd all  take the source and go elsewhere. I don't have access either, no responses.

There must be a way for CodePlex to let us in on this. I'll email them, otherwise the project will have to go elsewhere.

Oct 17, 2012 at 8:55 PM

Agreed, we should set a hard date of friday for a response and make the call at point.

Oct 18, 2012 at 11:41 AM

Hi All,

I have raised the issue of this project not being updated for three years and counting despite its bugs in the "Give Feedback" section:

http://codeplex.codeplex.com/workitem/26488

please comment to show your support!

Oct 24, 2012 at 10:54 PM

both me and the OP have been added as developers to this project.  I don't know what rights we have, but I will look into checking in a bug fix for the boolerr issue.  This could be the first release in over 3 years!

Nov 5, 2012 at 11:58 AM

any news on a release ?

 

Seems that most of the bugs discovered has something to do with the fact that the project has been built toward .NET 2.0, and most people today is using 4.0

Dec 5, 2012 at 2:40 PM

Gentle nudge.

Dec 6, 2012 at 11:22 AM

Is anything going on with this project? I know devs were recently added, but it's gone quiet. Are patches being tested/applied, or is this project effectively dead?

Dec 6, 2012 at 11:25 AM
Edited Dec 6, 2012 at 11:29 AM

Stuff is not going on with me, I was added and have just been swamped with work. I'll set aside some time if someone can help me identify small fixes that need to go in / get tested. I really need someone else to hassle / work with me.

 

Update: I've set aside a couple of hours Sunday evening to get started. 5pm-7pm GMT. If anyone wants a chat about their particular bug, catch me on twitter or Skype at the same handle as my username here.

Dec 6, 2012 at 12:43 PM

There are quite a few patches submitted I think, might be worth going through those and the issue list. Personally I applied changes in 8536 to my copy, plus a few of my own fixes (one detailed in 11397) and a fix for the reader close issue (10665 and several duplicates - detailed here http://exceldatareader.codeplex.com/discussions/403488).

Also, another one not listed, possibly more controversial, I trap and eat errors attempting to delete the temp file in the exception handler in ZipWorker.Extract(Stream). Probably it should trap and log the delete failure, in fact log4net might be worth adding to the project in general for debugging aid.

Are you able to add me as a dev? I am happy to add in the above changes (though I do wish it was a git repo as I more familiar with that for fork/pull requests).

Dec 6, 2012 at 12:48 PM

Can't add you as I'm not a coordinator but if you contact the people here http://www.codeplex.com/site/users/view/ExcelDataReader (I think CodePlex have taken it on now) and ask, they'll let you in. They let me in. I'll copy your notes to my diary for Sunday.

 

Thanks

Dec 6, 2012 at 1:18 PM
I promise I will go thru it before the end of the week.

Ian1971 <notifications@codeplex.com> wrote:

From: Ian1971

There are quite a few patches submitted I think, might be worth going through those and the issue list. Personally I applied changes in 8536 to my copy, plus a few of my own fixes (one detailed in 11397) and a fix for the reader close issue (10665 and several duplicates - detailed here http://exceldatareader.codeplex.com/discussions/403488).

Also, another one not listed, possibly more controversial, I trap and eat errors attempting to delete the temp file in the exception handler in ZipWorker.Extract(Stream). Probably it should trap and log the delete failure, in fact log4net might be worth adding to the project in general for debugging aid.

Are you able to add me as a dev? I am happy to add in the above changes (though I do wish it was a git repo as I more familiar with that for fork/pull requests).

Dec 7, 2012 at 4:08 PM

I've been added as a dev and assigned a couple of issues I found and fixed before to myself.

Dec 11, 2012 at 11:13 AM

I uploaded a couple of fixes. Did you get anywhere Ryan?

Dec 11, 2012 at 8:29 PM

I've wrestled with TFS (I use Subversion) and got nunit installed (I use MSTest normally) so that I don't impact the project setup. Now found a failing test which is a good candidate for starters. I think it is probably due to localisation issues as it is date parsing. I'll spend another hour and see where I get.

So not got anywhere significant, but moving in the right direction.

Dec 12, 2012 at 10:29 AM

Good stuff. Is that Test_num_double_date_bool_string you are looking at?

Dec 12, 2012 at 10:38 AM

It is, well figured.

It seems that the first four cells are encoded as a multi value range of integers (MulRk) but when opened in Excel, it presents the 3rd value as a date. I'm not sure if Excel is doing some magic and guessing that it should be a date based on the values in the same column but I don't think the raw data is there to reconstruct a date. That's what the date parsing test is looking for. The value stored seems to be a date serial.

So I can either look at how everyone else manages this value or change the test, but the test must have worked sometime?

MulRk:

http://msdn.microsoft.com/en-us/library/dd952688(v=office.12).aspx

Any insights? I'll create work item from this.

Dec 12, 2012 at 4:10 PM

Binary excel format is new to me, so I can't offer much advise.

I've just pushed a few fixes (issue 8536) btw.